Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for dynamic pairLimit #1137

Merged
merged 1 commit into from
Oct 26, 2023
Merged

add support for dynamic pairLimit #1137

merged 1 commit into from
Oct 26, 2023

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Oct 26, 2023

Reasoning

  • pairLimit it was hardcoded when making a request to pairs dex graphql
  • since the limit was set to 100, all the pairs created later did not contain the date such as marketCap, price, for example XBID-c7e360

Proposed Changes

  • Add new query to return total number of available pairs from DEX
  • refactoring of the getData method to allow the execution of the query without the declared variables

How to test

  • mex/pairs?size=200 -> should return 104 pairs
  • tokens/XBID-c7e360 -> marketCap, price attributes should be defined

@tanghel tanghel merged commit f573d95 into development Oct 26, 2023
5 checks passed
@tanghel tanghel deleted the SERVICES-1893-add-support-for-dynamic-pair-limit branch October 26, 2023 07:10
@cfaur09 cfaur09 added the feature New feature or request label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmatei gabrielmatei gabrielmatei approved these changes

@tanghel tanghel tanghel approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfaur09 @tanghel @gabrielmatei