Added CentOS7 as possible OS and added possibility to add comments to rules file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrlesmithjr
requested changes
Feb 18, 2020
|
@rogerniesten Glad this role has been useful for you. I very much appreciate the work you've done here and would be glad to get these merged in. |
|
@rogerniesten I need to get this role in sync from a structuring perspective, etc. I have been standardizing the CI tests as well. The current testing, checks are not working too great for sure. My question is whether you'd like me to get those changes in now? Which means a rebase on your part for this PR. Or, get this PR merged in and then make the structural changes? Which means you'll need to pull the new changes after the merge. Thoughts? |
|
As an FYI. This is what the new structure is being developed from. |
added 7 commits
February 28, 2020 17:03
…l is restarted [DHS-59]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We like your ansible role for shorewall very much. Unfortunately your role doesn't incorporate CentOS and we have to maintain some CentOS servers as well (beside a lot of Ubuntu servers).
The only difference I could find is the way the shorewall package has to be installed, so I enhanced your role for this.
I also added a comment field to the rules structure, so comments can be added to the entries in the rules file.
I think these enhancements would be beneficial for many people, so that's why I requested this pull request.