Scheduler: oversubscribe cores just a little to make up for slack #2315
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
from
fe6c4f6 to
e3f9d04
Compare
sylvestre
reviewed
Jan 10, 2025
| @@ -309,7 +309,7 @@ fn init_logging() { | |||
| } | |||
| } | |||
|
|
|||
| const MAX_PER_CORE_LOAD: f64 = 10f64; | |||
| const MAX_PER_CORE_LOAD: f64 = 2f64; | |||
There was a problem hiding this comment.
could you please document this variable ?
(i know it isn't your fault but as you are working on it)
There was a problem hiding this comment.
(In the next version that I forced-pushed - sorry, I'm more used to how it works in GitLab)
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
from
e3f9d04 to
ae01e21
Compare
...not by a factor of 10 as it was done previously
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
from
ae01e21 to
8593012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...not by factor of 10 as it was done previously