- Fix delete cookies check & update test_synonyms test

mozilla · Jan 13, 2025 · 1673664 · 1673664
1 parent 4b7d349
commit 1673664
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/playwright_tests/core/utilities.py b/playwright_tests/core/utilities.py
@@ -11,6 +11,8 @@
 from datetime import datetime
 from nltk import SnowballStemmer, WordNetLemmatizer
 from playwright.sync_api import Page, Locator
+
+from playwright_tests.messages.auth_pages_messages.fxa_page_messages import FxAPageMessages
 from playwright_tests.messages.homepage_messages import HomepageMessages
 from requests.exceptions import HTTPError
 from playwright_tests.pages.top_navbar import TopNavbar
@@ -307,8 +309,11 @@ def delete_cookies(self, tried_once=False, retries=3):
             try:
                 self.page.context.clear_cookies()
                 self.refresh_page()
-                self.page.wait_for_selector(top_navbar.TOP_NAVBAR_SIGNIN_SIGNUP_LOCATORS
-                                            ["signin_signup_button"], timeout=3000)
+                if FxAPageMessages.AUTH_PAGE_URL in self.get_page_url():
+                    break
+                else:
+                    self.page.wait_for_selector(top_navbar.TOP_NAVBAR_SIGNIN_SIGNUP_LOCATORS
+                                                ["signin_signup_button"], timeout=3000)
                 break
             except PlaywrightTimeoutError:
                 print("Cookies were not successfully deleted. Retrying...")

diff --git a/playwright_tests/test_data/search_synonym.py b/playwright_tests/test_data/search_synonym.py
@@ -8,7 +8,7 @@ class SearchSynonyms:
         'cache': ['cash', 'cookies'],
         'popup': ['pop up'],
         'pop up': ['popup'],
-        'popups': ['pop-up', 'pop-ups', 'pop ups'],
+        'popups': ['pop-up', 'pop-ups', 'pop ups', 'pops up'],
 
         # Actions
         'clear': ['delete', 'remove', 'deleting'],