Detect import.meta as module in .js files #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4399 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 54 54
Lines 2811 2812 +1
Branches 840 840
=======================================
+ Hits 2775 2776 +1
Misses 36 36
Continue to review full report at Codecov.
|
willdurand
requested changes
Jul 18, 2022
|
The requested changes have been made. |
willdurand
requested changes
Jul 22, 2022
|
The unit test has been re-added. |
willdurand
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4331 and #3639
When using import.meta in a .js file, the linter returns an error, "Cannot use 'import.meta' outside a module", unless the source type is detected as a module by the use of an import/export. This patch parses the code as a script if a .js file contains import.meta and it hasn't already been detected as a module by the use of an import/export. If the specific import.meta error is found during the catch block, then the source type is set as a module.
This patch does result in the code being parsed again, but that happens only in the specific situation that currently causes an error. Considering that the use of import.meta within a .js file is currently preventing addons from being able to pass the linter, I believe this is an acceptable workaround.
A unit test has also been added to test the patch.