various fixes #630
Merged
various fixes #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MathisGD
commented
Dec 5, 2023
•
MathisGD
commented
- cantina#13 (comment authorisations are for all markets)
- cantina#23 (misleading event natspec)
- cantina#24 (supply collateral)
- cantina#25 (withdraw collateral)
- cantina#48 (setFee natspec)
- cantina#90 (front-run repay)
- cantina#325 (bytes.concat)
- cantina#431 (authorization already set)
- cantina#503 (event emission order)
- cantina#670 (flashloan zero amount)
- cantina#686 (iirm natspec)
- cantina#699 (supply event feeRecipient)
MathisGD
requested review from
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
MathisGD
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
MathisGD
requested review from
a team,
adhusson,
Rubilmax,
QGarchery,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
MerlinEgalite
requested changes
Dec 11, 2023
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Rubilmax
reviewed
Dec 11, 2023
Rubilmax
approved these changes
Dec 11, 2023
MerlinEgalite
approved these changes
Dec 11, 2023
Jean-Grimal
approved these changes
Dec 11, 2023
Merged
QGarchery
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.