Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(liquidate): dont realize bad debt #544

Merged
merged 2 commits into from
Oct 17, 2023
Merged

test(liquidate): dont realize bad debt #544

merged 2 commits into from
Oct 17, 2023

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Oct 16, 2023

it was a simple one but I ended up refactoring it to avoid stack too deep and harmonize both tests

@Rubilmax Rubilmax marked this pull request as ready for review October 16, 2023 14:32
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to tell what is related to the refactor and what is related to the fix with all the changes

Jean-Grimal
Jean-Grimal previously approved these changes Oct 16, 2023
QGarchery
QGarchery previously approved these changes Oct 16, 2023
MerlinEgalite
MerlinEgalite previously approved these changes Oct 16, 2023
@MathisGD MathisGD merged commit f2ed54b into main Oct 17, 2023
4 checks passed
@MathisGD MathisGD deleted the test/liquidate branch October 17, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants