Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audit): fixing typo in security review report #541

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

tomrpl
Copy link
Contributor

@tomrpl tomrpl commented Oct 13, 2023

Updating the security review report

@MathisGD
Copy link
Contributor

isn't it better to keep the same date?

Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question, why changing the date?

@tomrpl
Copy link
Contributor Author

tomrpl commented Oct 17, 2023

@MathisGD @MerlinEgalite
They produced a new report for the typo, thus the date inside the doc has been updated as well.
Would you prefer it with the original data, but file updated?

@MathisGD
Copy link
Contributor

@tomrpl yes original date (we don't really care about the date of the edit)

@Rubilmax
Copy link
Collaborator

Rubilmax commented Oct 17, 2023

@tomrpl yes original date (we don't really care about the date of the edit)

the date inside the doc has been updated so it's weird to have different dates

@MathisGD
Copy link
Contributor

ok but if we find an other typo in 6 month we don't want to update the date right. What we care about is the date of the audit

@Rubilmax
Copy link
Collaborator

ok but if we find an other typo in 6 month we don't want to update the date right. What we care about is the date of the audit

I agree, but then we need to warn OZ not to update the date of the report?

@MathisGD MathisGD merged commit 7209539 into morpho-org:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants