Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect comment 36 #61

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix incorrect comment 36 #61

merged 3 commits into from
Nov 9, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax, Jean-Grimal, QGarchery, peyha and MathisGD and removed request for a team November 8, 2023 15:03
@MerlinEgalite MerlinEgalite marked this pull request as draft November 8, 2023 15:04
@MerlinEgalite MerlinEgalite marked this pull request as ready for review November 8, 2023 15:56
@MerlinEgalite MerlinEgalite force-pushed the fix/incorrect-comment-36 branch 2 times, most recently from fc42232 to 34a709a Compare November 8, 2023 16:14
@MerlinEgalite MerlinEgalite force-pushed the fix/incorrect-comment-36 branch from 34a709a to 1eff87c Compare November 8, 2023 16:15
Rubilmax
Rubilmax approved these changes Nov 8, 2023
View reviewed changes
src/libraries/MathLib.sol Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Nov 9, 2023
View reviewed changes
src/libraries/MathLib.sol Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Nov 9, 2023
View reviewed changes
src/libraries/MathLib.sol Outdated Show resolved Hide resolved
@MathisGD
docs: improve comment return zero
c82fc3d 
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MathisGD MathisGD merged commit bd0b5cd into refactor/curve Nov 9, 2023
3 checks passed
@MathisGD MathisGD deleted the fix/incorrect-comment-36 branch November 9, 2023 11:06
@MerlinEgalite
Copy link
Contributor Author

MerlinEgalite commented Nov 9, 2023 •
edited
Loading

please wait spearbit's review before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery QGarchery was automatically assigned from morpho-labs/protocol

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MerlinEgalite @Rubilmax @MathisGD @Jean-Grimal