fix warnings (#2832)

* fix: explicitly drop returned value

* fix: log DispatchError

* update cargo.lock

* fix warnings

pallets/erc20-xcm-bridge/Cargo.toml

@@ -8,6 +8,7 @@ version = "1.0.0"
 environmental = { workspace = true }
 ethereum-types = { workspace = true }
 serde = { workspace = true, optional = true, features = ["derive"] }
+log = { workspace = true }
 
 # Substrate
 frame-support = { workspace = true }

pallets/erc20-xcm-bridge/src/errors.rs

@@ -39,7 +39,8 @@ impl From<Erc20TransferError> for XcmError {
 			Erc20TransferError::ContractReturnInvalidValue => {
 				XcmError::FailedToTransactAsset("Erc20 contract return invalid value")
 			}
-			Erc20TransferError::DispatchError(_) => {
+			Erc20TransferError::DispatchError(err) => {
+				log::debug!("dispatch error: {:?}", err);
 				Self::FailedToTransactAsset("storage layer error")
 			}
 			Erc20TransferError::EvmCallFail => {

pallets/moonbeam-orbiters/src/benchmarks.rs

@@ -39,8 +39,8 @@ fn init<T: Config>() {
 fn create_funded_user<T: Config>(string: &'static str, n: u32, balance: u32) -> T::AccountId {
 	const SEED: u32 = 0;
 	let user = account(string, n, SEED);
-	T::Currency::make_free_balance_be(&user, balance.into());
-	T::Currency::issue(balance.into());
+	let _ = T::Currency::make_free_balance_be(&user, balance.into());
+	let _ = T::Currency::issue(balance.into());
 	user
 }
 

pallets/parachain-staking/src/benchmarks.rs

@@ -50,8 +50,8 @@ fn create_funded_user<T: Config>(
 	let user = account(string, n, SEED);
 	let min_candidate_stk = min_candidate_stk::<T>();
 	let total = min_candidate_stk + extra;
-	T::Currency::make_free_balance_be(&user, total);
-	T::Currency::issue(total);
+	let _ = T::Currency::make_free_balance_be(&user, total);
+	let _ = T::Currency::issue(total);
 	(user, total)
 }
 
@@ -123,8 +123,8 @@ fn create_account<T: Config>(
 		AccountBalance::Value(v) => v,
 	};
 
-	T::Currency::make_free_balance_be(&acc, initial_balance);
-	T::Currency::issue(initial_balance);
+	let _ = T::Currency::make_free_balance_be(&acc, initial_balance);
+	let _ = T::Currency::issue(initial_balance);
 
 	match action {
 		AccountAction::None => (),

runtime/moonbase/tests/common/mod.rs

@@ -24,11 +24,9 @@ use frame_support::{
 };
 use moonbase_runtime::{asset_config::AssetRegistrarMetadata, xcm_config::AssetType};
 pub use moonbase_runtime::{
-	currency::{GIGAWEI, SUPPLY_FACTOR, UNIT, WEI},
-	AccountId, AssetId, AssetManager, Assets, AsyncBacking, AuthorInherent, Balance, Balances,
-	CrowdloanRewards, Ethereum, Executive, Header, InflationInfo, ParachainStaking,
-	ParachainSystem, Range, Runtime, RuntimeCall, RuntimeEvent, System, TransactionConverter,
-	TransactionPaymentAsGasPrice, UncheckedExtrinsic, HOURS, WEEKS,
+	currency::UNIT, AccountId, AssetId, AssetManager, Assets, AsyncBacking, AuthorInherent,
+	Balance, Ethereum, InflationInfo, ParachainStaking, Range, Runtime, RuntimeCall, RuntimeEvent,
+	System, TransactionConverter, UncheckedExtrinsic, HOURS,
 };
 use nimbus_primitives::{NimbusId, NIMBUS_ENGINE_ID};
 use polkadot_parachain::primitives::HeadData;

runtime/moonbase/tests/evm_tracing.rs

@@ -26,6 +26,7 @@ mod tests {
 	use pallet_evm::AddressMapping;
 	use sp_core::{H160, U256};
 
+	use moonbeam_core_primitives::Header;
 	use moonbeam_rpc_primitives_debug::runtime_decl_for_debug_runtime_api::DebugRuntimeApi;
 	use std::str::FromStr;
 

runtime/moonbase/tests/integration_test.rs

@@ -39,10 +39,11 @@ use frame_support::{
 use moonbase_runtime::{
 	asset_config::{AssetRegistrarMetadata, ForeignAssetInstance},
 	xcm_config::{AssetType, SelfReserve},
-	AccountId, AssetId, AssetManager, Assets, Balances, CrowdloanRewards,
+	AccountId, AssetId, AssetManager, Assets, Balances, CrowdloanRewards, Executive,
 	OpenTechCommitteeCollective, ParachainStaking, PolkadotXcm, Precompiles, Runtime,
 	RuntimeBlockWeights, RuntimeCall, RuntimeEvent, System, TransactionPayment,
-	TreasuryCouncilCollective, XTokens, XcmTransactor, FOREIGN_ASSET_PRECOMPILE_ADDRESS_PREFIX,
+	TransactionPaymentAsGasPrice, TreasuryCouncilCollective, XTokens, XcmTransactor,
+	FOREIGN_ASSET_PRECOMPILE_ADDRESS_PREFIX, WEEKS,
 };
 use polkadot_parachain::primitives::Sibling;
 use precompile_utils::testing::MockHandle;
@@ -54,6 +55,7 @@ use std::str::from_utf8;
 use xcm_builder::{ParentIsPreset, SiblingParachainConvertsVia};
 use xcm_executor::traits::ConvertLocation;
 
+use moonbase_runtime::currency::{GIGAWEI, WEI};
 use moonbeam_xcm_benchmarks::weights::XcmWeight;
 use moonkit_xcm_primitives::AccountIdAssetIdConversion;
 use nimbus_primitives::NimbusId;
@@ -2804,7 +2806,7 @@ mod fee_tests {
 	};
 	use moonbase_runtime::{
 		currency, BlockWeights, FastAdjustingFeeUpdate, LengthToFee, MinimumMultiplier,
-		TargetBlockFullness, NORMAL_WEIGHT, WEIGHT_PER_GAS,
+		TargetBlockFullness, TransactionPaymentAsGasPrice, NORMAL_WEIGHT, WEIGHT_PER_GAS,
 	};
 	use sp_runtime::{BuildStorage, FixedPointNumber, Perbill};
 

runtime/moonbase/tests/runtime_apis.rs

@@ -26,6 +26,8 @@ use pallet_evm::{Account as EVMAccount, AddressMapping, FeeCalculator};
 use sp_core::{ByteArray, H160, H256, U256};
 
 use fp_rpc::runtime_decl_for_ethereum_runtime_rpc_api::EthereumRuntimeRPCApi;
+use moonbase_runtime::{Executive, TransactionPaymentAsGasPrice};
+use moonbeam_core_primitives::Header;
 use moonbeam_rpc_primitives_txpool::runtime_decl_for_tx_pool_runtime_api::TxPoolRuntimeApi;
 use nimbus_primitives::runtime_decl_for_nimbus_api::NimbusApi;
 use std::{collections::BTreeMap, str::FromStr};

runtime/moonbeam/tests/common/mod.rs

@@ -23,13 +23,10 @@ use frame_support::{
 	traits::{OnFinalize, OnInitialize},
 };
 pub use moonbeam_runtime::{
-	asset_config::AssetRegistrarMetadata,
-	currency::{GIGAWEI, GLMR, SUPPLY_FACTOR, WEI},
-	xcm_config::AssetType,
-	AccountId, AssetId, AssetManager, AsyncBacking, AuthorInherent, Balance, Balances,
-	CrowdloanRewards, Ethereum, Executive, Header, InflationInfo, ParachainStaking, Range, Runtime,
-	RuntimeCall, RuntimeEvent, System, TransactionConverter, TransactionPaymentAsGasPrice,
-	UncheckedExtrinsic, HOURS, WEEKS,
+	asset_config::AssetRegistrarMetadata, currency::GLMR, xcm_config::AssetType, AccountId,
+	AssetId, AssetManager, AsyncBacking, AuthorInherent, Balance, Ethereum, InflationInfo,
+	ParachainStaking, Range, Runtime, RuntimeCall, RuntimeEvent, System, TransactionConverter,
+	UncheckedExtrinsic, HOURS,
 };
 use nimbus_primitives::{NimbusId, NIMBUS_ENGINE_ID};
 use polkadot_parachain::primitives::HeadData;

runtime/moonbeam/tests/evm_tracing.rs

@@ -26,6 +26,7 @@ mod tests {
 	use pallet_evm::AddressMapping;
 	use sp_core::{H160, U256};
 
+	use moonbeam_core_primitives::Header;
 	use moonbeam_rpc_primitives_debug::runtime_decl_for_debug_runtime_api::DebugRuntimeApi;
 	use std::str::FromStr;
 

runtime/moonbeam/tests/integration_test.rs

@@ -32,14 +32,16 @@ use frame_support::{
 	weights::{constants::WEIGHT_REF_TIME_PER_SECOND, Weight},
 	StorageHasher, Twox128,
 };
+use moonbeam_runtime::currency::{GIGAWEI, WEI};
 use moonbeam_runtime::{
 	asset_config::ForeignAssetInstance,
 	currency::GLMR,
 	xcm_config::{CurrencyId, SelfReserve},
-	AccountId, Balances, CrowdloanRewards, OpenTechCommitteeCollective, ParachainStaking,
-	PolkadotXcm, Precompiles, Runtime, RuntimeBlockWeights, RuntimeCall, RuntimeEvent, System,
-	TransactionPayment, TreasuryCouncilCollective, XTokens, XcmTransactor,
-	FOREIGN_ASSET_PRECOMPILE_ADDRESS_PREFIX,
+	AccountId, Balances, CrowdloanRewards, Executive, OpenTechCommitteeCollective,
+	ParachainStaking, PolkadotXcm, Precompiles, Runtime, RuntimeBlockWeights, RuntimeCall,
+	RuntimeEvent, System, TransactionPayment, TransactionPaymentAsGasPrice,
+	TreasuryCouncilCollective, XTokens, XcmTransactor, FOREIGN_ASSET_PRECOMPILE_ADDRESS_PREFIX,
+	WEEKS,
 };
 use moonbeam_xcm_benchmarks::weights::XcmWeight;
 use moonkit_xcm_primitives::AccountIdAssetIdConversion;
@@ -2674,7 +2676,7 @@ mod fee_tests {
 	};
 	use moonbeam_runtime::{
 		currency, LengthToFee, MinimumMultiplier, RuntimeBlockWeights, SlowAdjustingFeeUpdate,
-		TargetBlockFullness, NORMAL_WEIGHT, WEIGHT_PER_GAS,
+		TargetBlockFullness, TransactionPaymentAsGasPrice, NORMAL_WEIGHT, WEIGHT_PER_GAS,
 	};
 	use sp_core::Get;
 	use sp_runtime::{BuildStorage, FixedPointNumber, Perbill};

runtime/moonbeam/tests/runtime_apis.rs

@@ -26,7 +26,9 @@ use pallet_evm::{Account as EVMAccount, AddressMapping, FeeCalculator};
 use sp_core::{ByteArray, H160, H256, U256};
 
 use fp_rpc::runtime_decl_for_ethereum_runtime_rpc_api::EthereumRuntimeRPCApi;
+use moonbeam_core_primitives::Header;
 use moonbeam_rpc_primitives_txpool::runtime_decl_for_tx_pool_runtime_api::TxPoolRuntimeApi;
+use moonbeam_runtime::{Executive, TransactionPaymentAsGasPrice};
 use nimbus_primitives::runtime_decl_for_nimbus_api::NimbusApi;
 use std::{collections::BTreeMap, str::FromStr};
 

runtime/moonriver/tests/common/mod.rs

@@ -23,13 +23,10 @@ use frame_support::{
 	traits::{OnFinalize, OnInitialize},
 };
 pub use moonriver_runtime::{
-	asset_config::AssetRegistrarMetadata,
-	currency::{GIGAWEI, MOVR, SUPPLY_FACTOR, WEI},
-	xcm_config::AssetType,
-	AccountId, AssetId, AssetManager, AsyncBacking, AuthorInherent, Balance, Balances,
-	CrowdloanRewards, Ethereum, Executive, Header, InflationInfo, ParachainStaking, Range, Runtime,
-	RuntimeCall, RuntimeEvent, System, TransactionConverter, TransactionPaymentAsGasPrice,
-	UncheckedExtrinsic, HOURS, WEEKS,
+	asset_config::AssetRegistrarMetadata, currency::MOVR, xcm_config::AssetType, AccountId,
+	AssetId, AssetManager, AsyncBacking, AuthorInherent, Balance, Ethereum, InflationInfo,
+	ParachainStaking, Range, Runtime, RuntimeCall, RuntimeEvent, System, TransactionConverter,
+	UncheckedExtrinsic, HOURS,
 };
 use nimbus_primitives::{NimbusId, NIMBUS_ENGINE_ID};
 use polkadot_parachain::primitives::HeadData;

runtime/moonriver/tests/evm_tracing.rs

@@ -26,6 +26,7 @@ mod tests {
 	use pallet_evm::AddressMapping;
 	use sp_core::{H160, U256};
 
+	use moonbeam_core_primitives::Header;
 	use moonbeam_rpc_primitives_debug::runtime_decl_for_debug_runtime_api::DebugRuntimeApi;
 	use std::str::FromStr;
 

runtime/moonriver/tests/integration_test.rs

@@ -22,24 +22,24 @@ mod common;
 use common::*;
 
 use fp_evm::{Context, IsPrecompileResult};
+use frame_support::traits::fungible::Inspect;
 use frame_support::{
 	assert_noop, assert_ok,
 	dispatch::DispatchClass,
-	traits::{
-		fungible::Inspect, Currency as CurrencyT, EnsureOrigin, PalletInfo, StorageInfo,
-		StorageInfoTrait,
-	},
+	traits::{Currency as CurrencyT, EnsureOrigin, PalletInfo, StorageInfo, StorageInfoTrait},
 	weights::{constants::WEIGHT_REF_TIME_PER_SECOND, Weight},
 	StorageHasher, Twox128,
 };
 use moonbeam_xcm_benchmarks::weights::XcmWeight;
 use moonkit_xcm_primitives::AccountIdAssetIdConversion;
+use moonriver_runtime::currency::{GIGAWEI, WEI};
 use moonriver_runtime::{
 	asset_config::ForeignAssetInstance,
 	xcm_config::{CurrencyId, SelfReserve},
-	AssetId, OpenTechCommitteeCollective, PolkadotXcm, Precompiles, RuntimeBlockWeights,
-	TransactionPayment, TreasuryCouncilCollective, XTokens, XcmTransactor,
-	FOREIGN_ASSET_PRECOMPILE_ADDRESS_PREFIX,
+	AssetId, Balances, CrowdloanRewards, Executive, OpenTechCommitteeCollective, PolkadotXcm,
+	Precompiles, RuntimeBlockWeights, TransactionPayment, TransactionPaymentAsGasPrice,
+	TreasuryCouncilCollective, XTokens, XcmTransactor, FOREIGN_ASSET_PRECOMPILE_ADDRESS_PREFIX,
+	WEEKS,
 };
 use nimbus_primitives::NimbusId;
 use pallet_evm::PrecompileSet;
@@ -2587,7 +2587,7 @@ mod fee_tests {
 	};
 	use moonriver_runtime::{
 		currency, LengthToFee, MinimumMultiplier, RuntimeBlockWeights, SlowAdjustingFeeUpdate,
-		TargetBlockFullness, NORMAL_WEIGHT, WEIGHT_PER_GAS,
+		TargetBlockFullness, TransactionPaymentAsGasPrice, NORMAL_WEIGHT, WEIGHT_PER_GAS,
 	};
 	use sp_core::Get;
 	use sp_runtime::{BuildStorage, FixedPointNumber, Perbill};

runtime/moonriver/tests/runtime_apis.rs

@@ -19,14 +19,16 @@
 mod common;
 use common::*;
 
-use fp_evm::GenesisAccount;
+use fp_evm::{FeeCalculator, GenesisAccount};
 use frame_support::assert_ok;
 use nimbus_primitives::NimbusId;
-use pallet_evm::{Account as EVMAccount, AddressMapping, FeeCalculator};
+use pallet_evm::{Account as EVMAccount, AddressMapping};
 use sp_core::{ByteArray, H160, H256, U256};
 
 use fp_rpc::runtime_decl_for_ethereum_runtime_rpc_api::EthereumRuntimeRPCApi;
+use moonbeam_core_primitives::Header;
 use moonbeam_rpc_primitives_txpool::runtime_decl_for_tx_pool_runtime_api::TxPoolRuntimeApi;
+use moonriver_runtime::{Executive, TransactionPaymentAsGasPrice};
 use nimbus_primitives::runtime_decl_for_nimbus_api::NimbusApi;
 use std::{collections::BTreeMap, str::FromStr};