Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby-3510] Add Ruby-3.3 to testing matrix #2891

Closed

Conversation

adviti-mishra
Copy link
Contributor

Added Ruby-3.3 to the testing matrix for the Ruby Driver per this ticket

@jamis
Copy link
Contributor

jamis commented Aug 7, 2024

This looks promising! Sadly, there's always a danger when updating the Ruby version, and we're running into some of that here. There are several of the tests that are failing on 3.3. It looks like Ruby 3.3 changed the exception that is raised when a socket cannot resolve a hostname:

$ ruby -v -rsocket -e 'TCPSocket.new("bogus.address", 1000)'
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]
-e:1:in `initialize': getaddrinfo: nodename nor servname provided, or not known (SocketError)
	from -e:1:in `new'
	from -e:1:in `<main>'
$ ruby -v -rsocket -e 'TCPSocket.new("bogus.address", 1000)'
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [arm64-darwin23]
-e:1:in `initialize': getaddrinfo: nodename nor servname provided, or not known (Socket::ResolutionError)
	from -e:1:in `new'
	from -e:1:in `<main>'

The tests (at least?) are explicitly looking for SocketError, which isn't robust enough here.

Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See my previous comment.)

@adviti-mishra adviti-mishra force-pushed the 3510-3.3-to-testing-matrix branch from 04bb7ae to 6a17cfb Compare August 8, 2024 22:00
@adviti-mishra adviti-mishra requested a review from jamis August 8, 2024 22:01
@kalicki
Copy link

kalicki commented Sep 10, 2024

up! News?

@jamis
Copy link
Contributor

jamis commented Sep 11, 2024

Hey @kalicki -- this is still in progress but ran into some roadblocks related to our testing infrastructure. Stay tuned.

@kalicki
Copy link

kalicki commented Sep 11, 2024

Thanks @jamis! only for testing infrastructure? is it safe to consider 3.3 on my side?

@jamis
Copy link
Contributor

jamis commented Sep 11, 2024

We can't officially guarantee 3.3 support until we have CI running it, but FWIW, I do most of my development on it using 3.3. Caveat emptor, and all that.

@jamis
Copy link
Contributor

jamis commented Oct 21, 2024

Fixed in #2902

@jamis jamis closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants