-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby-3510] Add Ruby-3.3 to testing matrix #2891
[Ruby-3510] Add Ruby-3.3 to testing matrix #2891
Conversation
This looks promising! Sadly, there's always a danger when updating the Ruby version, and we're running into some of that here. There are several of the tests that are failing on 3.3. It looks like Ruby 3.3 changed the exception that is raised when a socket cannot resolve a hostname: $ ruby -v -rsocket -e 'TCPSocket.new("bogus.address", 1000)'
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]
-e:1:in `initialize': getaddrinfo: nodename nor servname provided, or not known (SocketError)
from -e:1:in `new'
from -e:1:in `<main>'
$ ruby -v -rsocket -e 'TCPSocket.new("bogus.address", 1000)'
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [arm64-darwin23]
-e:1:in `initialize': getaddrinfo: nodename nor servname provided, or not known (Socket::ResolutionError)
from -e:1:in `new'
from -e:1:in `<main>' The tests (at least?) are explicitly looking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See my previous comment.)
…_rubies to indicate 3.3 is supported
04bb7ae
to
6a17cfb
Compare
up! News? |
Hey @kalicki -- this is still in progress but ran into some roadblocks related to our testing infrastructure. Stay tuned. |
Thanks @jamis! only for testing infrastructure? is it safe to consider 3.3 on my side? |
We can't officially guarantee 3.3 support until we have CI running it, but FWIW, I do most of my development on it using 3.3. Caveat emptor, and all that. |
Fixed in #2902 |
Added Ruby-3.3 to the testing matrix for the Ruby Driver per this ticket