Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-37137: Update BSON page references #2844

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Feb 26, 2024

@norareidy norareidy marked this pull request as ready for review February 26, 2024 21:42
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion.

@@ -88,7 +88,7 @@ This release includes the following new features:
5.1/5.2/5.3) or newer to use the ``count`` command when API strict is enabled,
or avoid setting ``api_strict: true`` when constructing ``Mongo::Client``
instances with server versions 5.0.0-5.0.7 and 5.1.0-5.3.1.
- The DBRef class has been moved to bson-ruby. For backwards compatibility,
- The DBRef class has been moved to ``bson-ruby``. For backwards compatibility,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Since DBRef is a class name, I think formatting with monospace would make this consistent:

Suggested change
- The DBRef class has been moved to ``bson-ruby``. For backwards compatibility,
- The ``DBRef`` class has been moved to ``bson-ruby``. For backwards compatibility,

docs/index.txt Show resolved Hide resolved
@jamis jamis merged commit 517891b into mongodb:2.19-stable Feb 28, 2024
295 of 327 checks passed
@norareidy norareidy deleted the DOCSP-37137-fix-bson-references branch February 28, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants