MONGOID-5552 session should not change the client that created it #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the complete solution (yet), but this is a step towards it.
The
Mongo::Sessionclass was previously setting the session instance's@clientvariable toclient.use(:admin)for some reason. I suspect it is because the spec requires certain commands (startSessionandendSessions) to be executed against the admin database. However, we don't ever issue those commands;startSessionis only needed if you want the server to generate session IDs (and we do it ourselves), andendSessions...well...I don't know why that's not present.So, the point is: the session doesn't need a handle to the
admindatabase. And even if it needed one to execute those commands, the session's client shouldn't be changed in any way from the client that initialized it.