RUBY-1813 Discard ServerSessions involved in network errors #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo
approved these changes
Jan 15, 2024
Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
comandeo
pushed a commit
to comandeo/mongo-ruby-driver
that referenced
this pull request
Jan 24, 2024
…2825) * RUBY-1813 Discard ServerSessions involved in network errors * no need to test the now-non-existant SessionPool.create method * Tweak from code review Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> * Another tweak from code review Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> --------- Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
dirtyflag toServerSession, and set it when a network error occurs. When checking the session back into the session pool, discard the session if it was marked dirty.ref: RUBY-1813, DRIVERS-649, also RUBY-3000, RUBY-3031