Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUBY-1791 Raise if transactions not supported #2822

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

comandeo
Copy link

No description provided.

@comandeo comandeo force-pushed the 1791-raise-error-on-pre-4.2 branch from f87e526 to d904841 Compare January 11, 2024 12:21
@comandeo comandeo marked this pull request as ready for review January 12, 2024 08:42
@comandeo comandeo requested a review from jamis January 12, 2024 08:42
Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one comment about rubocop. 🤷

@@ -0,0 +1,36 @@
# frozen_string_literal: true
# rubocop:todo all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new files, I think we should probably apply the linter from the beginning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@comandeo comandeo requested a review from jamis January 15, 2024 12:21
@comandeo comandeo merged commit 5f4a7e3 into mongodb:master Jan 15, 2024
45 of 46 checks passed
@comandeo comandeo deleted the 1791-raise-error-on-pre-4.2 branch January 15, 2024 14:26
comandeo pushed a commit to comandeo/mongo-ruby-driver that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants