RUBY-3298 Add container info to handshake metadata #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo
suggested changes
Jan 11, 2024
comandeo
approved these changes
Jan 12, 2024
comandeo
pushed a commit
to comandeo/mongo-ruby-driver
that referenced
this pull request
Jan 24, 2024
* RUBY-3298 include container info in handshake metadata * make sure it works even when faas info is not present * look for .dockerenv, not Dockerfile * add a test to check the value of DOCKERENV_PATH * linter appeasement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
:containerkey to the environment document that is set with the handshake metadata. The container may include a:runtimekey (for Docker) and/or an:orchestratorkey (for Kubernetes).