refactor: Rewrite the ESLint config file for this repo with Flat Config #355
+74
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamsha
commented
Dec 9, 2024
There was a problem hiding this comment.
fixed with unicorn/prefer-export-from rule.
| @@ -28,7 +28,7 @@ module.exports = { | |||
| 'import/core-modules': [], | |||
| 'import/ignore': [ | |||
| 'node_modules', | |||
| '\\.(coffee|scss|css|less|hbs|svg|json|jpg|jpeg|png|webp)$', | |||
| String.raw`\.(coffee|scss|css|less|hbs|svg|json|jpg|jpeg|png|webp)$`, | |||
There was a problem hiding this comment.
fixed with unicorn/prefer-string-raw
| @@ -39,12 +39,11 @@ module.exports = { | |||
| name: 'isNaN', | |||
| message: 'Use Number.isNaN instead.', | |||
| }, | |||
| ].concat( | |||
| confusingBrowserGlobals.map((g) => ({ | |||
| ...confusingBrowserGlobals.map((g) => ({ | |||
There was a problem hiding this comment.
fixed with unicorn/prefer-spread rule.
Comment on lines
+3
to
+4
| const { readdirSync } = require('node:fs'); | ||
| const path = require('node:path'); |
There was a problem hiding this comment.
fixed with unicorn/prefer-node-protocol rule.
| }) | ||
| .map((dirnet) => extractFilePath(dirnet, dir)) | ||
| .flat(); | ||
| }).flatMap((dirnet) => extractFilePath(dirnet, directory)); |
There was a problem hiding this comment.
fixed with unicorn/prefer-array-flat-map rule.
|
|
||
| test('parsable all eslintrc format configs', () => { | ||
| const dir = resolve(join(__dirname, '../configs/eslintrc')); | ||
| const directory = path.resolve(path.join(__dirname, '../configs/eslintrc')); |
There was a problem hiding this comment.
fixed with unicorn/prevent-abbreviations rule.
7 tasks
wakamsha
commented
Dec 9, 2024
There was a problem hiding this comment.
This file was installed for snapshot testing, but it was found to be unnecessary so I deleted it.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
When ESLint is updated to v9 in #354,
eslintrcwill be deprecated, and it will become difficult to use.eslintrc.jsfor this repository. Therefore, I rewrote.eslintrc.jsaseslint.config.mjsin advance.In addition, as a result of this, invalid code that was not detected before is now properly detected, so I fixed them at this time.
Linked PR / Issues
Type of change
Pre-flight checklist
References