tests: add validation that config has OSVersion set #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up from 94ddeb7 to ensure that the expected OSVersion is set on the respective image configs. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
tonistiigi
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Can we also test the reg-like target where correct base image is resolved. There is also a case where the user either doesn't set osversion directly or sets one where base image doesn't match exactly but via fallback. Iiuc the result image should then have the osversion from the base image, rather than from the user input.
tonistiigi
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from 94ddeb7 to ensure that the expected OSVersion is set on the respective image configs.