Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: sever semconv relationship to otel sdk #5503

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jsternberg
Copy link
Collaborator

Copies over the telemetry sdk detection to utilize our own version of semconv rather than mix the versions between different packages. This will keep a consistent schema url instead of constantly chasing whichever one the otel sdk is using.

The only thing left from the otel sdk is WithFromEnv which is schemaless and won't conflict for that reason so we can continue to use it.

Copies over the telemetry sdk detection to utilize our own version of
semconv rather than mix the versions between different packages. This
will keep a consistent schema url instead of constantly chasing
whichever one the otel sdk is using.

The only thing left from the otel sdk is `WithFromEnv` which is
schemaless and won't conflict for that reason so we can continue to use
it.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@jsternberg
Copy link
Collaborator Author

GitHub is saying there's a failing test but there doesn't appear to be a failing test.

@thaJeztah
Copy link
Member

Looks like some timeout; I'll kick it;

docker create -v /root/.cache -v /root/.cache/registry -v /go/pkg/mod --name buildkit-test-cache alpine
Unable to find image 'alpine:latest' locally
Error response from daemon: Head "https://registry-1.docker.io/v2/library/alpine/manifests/latest": Get "https://auth.docker.io/token?account=githubactions&scope=repository%3Alibrary%2Falpine%3Apull&service=registry.docker.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Error: Process completed with exit code 1.

@thompson-shaun thompson-shaun added this to the v0.18.0 milestone Nov 13, 2024
@tonistiigi tonistiigi merged commit 5cd5a63 into moby:master Nov 18, 2024
92 checks passed
@jsternberg jsternberg deleted the otel-semconv-sever branch November 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants