Dockerfile: update containerd binary to v2.0.0 #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
containerd-2.0
branch
from
514961a to
dd53dab
Compare
AkihiroSuda
force-pushed
the
containerd-2.0
branch
2 times, most recently
from
52354c8 to
3b9210a
Compare
AkihiroSuda
force-pushed
the
containerd-2.0
branch
from
3b9210a to
5ac88d4
Compare
AkihiroSuda
changed the title
AkihiroSuda
commented
Nov 5, 2024
AkihiroSuda
force-pushed
the
containerd-2.0
branch
2 times, most recently
from
59bb74c to
555b636
Compare
tonistiigi
reviewed
Nov 8, 2024
Dockerfile
Outdated
| ARG TARGETPLATFORM | ||
| ENV CGO_ENABLED=1 BUILDTAGS=no_btrfs GO111MODULE=off | ||
| RUN xx-apk add musl-dev gcc && xx-go --wrap | ||
| RUN --mount=target=/root/.cache,type=cache <<EOT | ||
| COPY --chmod=755 <<EOT /build.sh |
There was a problem hiding this comment.
Actual bug discovered by build check.
There was a problem hiding this comment.
Variables should be defined before their use
UndefinedVar: Usage of undefined variable '$ext'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
5e16acf to
d13efaa
Compare
5 tasks
|
Needs a rebase, conflicts with changes in |
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
containerd-2.0
branch
from
d13efaa to
c399353
Compare
|
Rebased |
crazy-max
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Missing containerd-1.7 entry in this matrix:
buildkit/.github/workflows/.test.yml
Line 114 in 11f4528
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
containerd-2.0
branch
from
c399353 to
b1adeed
Compare
Fixed |
slonopotamus
approved these changes
Nov 14, 2024
crazy-max
approved these changes
Nov 14, 2024
|
Are we waiting for anything here or it can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.