frontend: handle multiple platforms when using the lint rule check functionality #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daghack
force-pushed
the
multiplatform-lint-checks
branch
4 times, most recently
from
63d55be to
e6bb4d2
Compare
3 tasks
daghack
force-pushed
the
multiplatform-lint-checks
branch
2 times, most recently
from
b518d93 to
3de6f7f
Compare
daghack
force-pushed
the
multiplatform-lint-checks
branch
6 times, most recently
from
5b278ef to
82133e4
Compare
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
daghack
force-pushed
the
multiplatform-lint-checks
branch
from
82133e4 to
d1e8f71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue identified in buildx#2708
Currently, using the rule check functionality doesn't respect
--platformflags, which causes issues when trying to check images which rely on images not machine the host machine architecture. This update runs the check for each platform requested, and merges duplicate check warnings.