Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify the purpose of the syntax parser directive #4519

Merged

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Jan 3, 2024

Addresses docker/docs#18946

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested review from tonistiigi and crazy-max January 3, 2024 15:51
@crazy-max crazy-max merged commit c7edff7 into moby:master Jan 4, 2024
13 checks passed
@dvdksn dvdksn deleted the docs-dockerfile-clarify-syntax-directive branch January 4, 2024 10:54
@thernstig
Copy link

@dvdksn how would one see the built-in version used if not specifying the syntax directive? I have not seen anywhere it mentioned. Using docker info does not show it, but maybe it should?

@dvdksn
Copy link
Collaborator Author

dvdksn commented Jan 4, 2024

@thernstig that would be nice. Unfortunately it's complicated to do, but hopefully one day. It's a long story, but the short version is that the docker commands can't get this information from BuildKit, because BuildKit itself isn't aware of what syntax version it ships with.

@thernstig
Copy link

@dvdksn if we just consider docs online then, where would this info be available which with BuildKit version -> docker frontend version?

@dvdksn
Copy link
Collaborator Author

dvdksn commented Jan 10, 2024

@thernstig the best way to find out your default frontend version is to find the most recent stable Dockerfile release https://docs.docker.com/build/dockerfile/release-notes/ prior to the release of the buildkit version you're on.

@thernstig
Copy link

@thernstig the best way to find out your default frontend version is to find the most recent stable Dockerfile release https://docs.docker.com/build/dockerfile/release-notes/ prior to the release of the buildkit version you're on.

Thanks! Wish it was documented somehow more readily available for users to know this to get a releation between BuiltKit version <-> which dockerfile frontend version it contains in the docs (and later the CLI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants