Refactor NewWorkerOpt function so it accepts a pre-created containerd client #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client This gives calling side more flexibility and allows to avoid creation of redundant client in Moby. Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
tonistiigi
reviewed
Oct 23, 2023
| @@ -80,13 +70,13 @@ func newContainerd(root string, client *containerd.Client, snapshotterName, ns s | |||
| if apparmorProfile != "" { | |||
| xlabels[wlabel.ApparmorProfile] = apparmorProfile | |||
| } | |||
| xlabels[wlabel.ContainerdNamespace] = ns | |||
| xlabels[wlabel.ContainerdNamespace] = client.DefaultNamespace() | |||
There was a problem hiding this comment.
It doesn't look like containerd guarantees that DefaultNamespace() returns a non-zero value. In that case we need to validate it in this function before using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives calling side more flexibility and allows to avoid creation of redundant client in Moby.