Release 0.7.1 (#101)

* fix: correct argument names for S3 generic CRAN issued a new policy. The first argument of S3 methods must coincide with the generic Version: 0.7.0 Check: S3 generic/method consistency Result: WARN as_data_backend: function(data, primary_key, ...) as_data_backend.OMLRun: function(x, primary_key, ...) See section ‘Generic functions and methods’ in the ‘Writing R Extensions’ manual. * fix: rename variable in function
mlr-org · Mar 14, 2023 · 44a4f19 · 44a4f19
1 parent a27ec01
commit 44a4f19
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: mlr3oml
 Title: Connector Between 'mlr3' and 'OpenML'
-Version: 0.7.0
+Version: 0.7.1
 Authors@R:c(
     person("Michel", "Lang", , "michellang@gmail.com", role = "aut",
            comment = c(ORCID = "0000-0001-9754-0393")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# mlr3oml 0.7.1
+
+* Fixed argument names of S3 method for `as_data_backend` to comply with new CRAN checks
+
 # mlr3oml 0.7.0
 
 * feature: Add argument `task_type` to function `list_oml_tasks()`.

diff --git a/R/OMLRun.R b/R/OMLRun.R
@@ -222,8 +222,8 @@ as_task.OMLRun = function(x, ...) {
 
 #' @importFrom mlr3 as_data_backend
 #' @export
-as_data_backend.OMLRun = function(x, primary_key = NULL, ...) {
-  as_data_backend(x$data, primary_key = primary_key, ...)
+as_data_backend.OMLRun = function(data, primary_key = NULL, ...) {
+  as_data_backend(data$data, primary_key = primary_key, ...)
 }
 
 #' @importFrom mlr3 as_resampling