Fix: variable become undefined when extension not exist or connection… #868
Conversation
miurahr
force-pushed
the
topic/miurahr/extension-may-not-exist
branch
from
a30786b to
690f798
Compare
|
@tsteven4 could you please check the change? |
miurahr
force-pushed
the
topic/miurahr/extension-may-not-exist
branch
from
dd721f5 to
107dbc2
Compare
… error - Fixed the issue #867 Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/extension-may-not-exist
branch
from
107dbc2 to
98fda2e
Compare
|
I agree I messed this up. I have an alternative fix in process. I will submit it for consideration. |
| @@ -442,11 +442,12 @@ def _get_archives_base(self, name, target_packages): | |||
| try: | |||
| extensions_xml_text = self._download_update_xml(extensions_xml_url, True) | |||
| except ArchiveDownloadError: | |||
| # In case _download_update_xml ignores the hash and tries to get the url. | |||
| # In case _download_update_xml failed to get the url because of no extension. | |||
There was a problem hiding this comment.
The primary failure when the extension doesn't exist is ChecksumDownloadFailure, which is caught by download_update_xml. I had to modify the code to simulate getting through that and failing with an ArchiveDownloadError.
There was a problem hiding this comment.
and I see in #867 the OP had set INSECURE_NOT_FOR_PRODUCTION_ignore_hash: True
So I think the original comment is more accurate.
There was a problem hiding this comment.
When _download_update_xml method failed to download sha256 checksum, it does not throw exception but set xml_hash = None and call get_url.
The exception is thrown from get_url that try to download Updates.xml itself.
So when got ArchiveDownloadError here, it means that it failed to download Update.xml not hash.
There was a problem hiding this comment.
Assuming Settings.ignore_hash is False download_update_xml catches ChecksumDownloadFailure and RETURNS None. It doesn't call get_url (silent = True). This is the normal production behavior.
The OP set ignore_hash to True which behaves as you indicated.
| if extensions_xml_text: | ||
| self.logger.info("Found extension {}".format(ext)) | ||
| update_xmls.append(UpdateXmls(extensions_target_folder, extensions_xml_text)) |
There was a problem hiding this comment.
I moved this into the try block but putting them in the else block may be preferred. There are two places in metadata.py
related to "except (ChecksumDownloadFailure, ArchiveDownloadError)" where I also added additional code to the try block where an else block might be preferred.
There was a problem hiding this comment.
While you are in here it would be good to change
Line 436 in 98fda2e
to
for ext in QtRepoProperty.known_extensions(self.version):so we only have the list of extensions in one place.
It is out of scope of the fix. |
… error