Fixes #114 #124
Merged
Fixes #114 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptcNOP
reviewed
Apr 27, 2018
| # of MultiScannerTask | ||
| if not storage_ids: | ||
| raise ValueError('Report failed to index') | ||
|
|
||
| # Update the task DB to reflect that the task is done | ||
| db.update_task( |
There was a problem hiding this comment.
Not exactly related to this PR, but while we're on the subject...should we be doing any checks to see if db.update_task was successful?
There was a problem hiding this comment.
That's a good point. I added an issue for this (#129), since I think it will need a little more of a reworking of the sql_driver.py. I think this sort of error handling should be handled by the ORM layer, with an exception or w/e raised to the caller. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.