drop python<=3.7 support #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://endoflife.date/python python 3.7 has been EOSed almost year ago. Filter all code over `pyupgrade --py3.8-plus`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
|
Thanks for the PR! But for such a small, simple project I'd rather not drop support for things that work just fine without a reason. |
|
From what I see, that link makes a good case to at least keep 3.7, and might as well keep 3.6, since removing it doesn't solve anything that I'm aware of. Does removing support where we know it works fine with no other changes solve a problem for you that I'm not seeing? |
|
With |
|
OK. I don't like to drop support before maintaining support causes a problem. 3.5 is proving a pain, so I'm fine bumping to >=3.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://endoflife.date/python python 3.7 has been EOSed almost year ago.
Filter all code over
pyupgrade --py3.8-plus.