Upgrade Node to 22 and update the dependenies to be compatible with node 22 as node v16 is depricated #554
Conversation
Dockerfile.dev
Outdated
| @@ -44,7 +44,9 @@ RUN mv /app/database-docker/db/ /app/ && rm -rf /app/database-docker/ | |||
| RUN echo "host all all 0.0.0.0/0 md5" >> /etc/postgresql/15/main/pg_hba.conf | |||
| RUN echo "listen_addresses='*'" >> /etc/postgresql/15/main/postgresql.conf | |||
| RUN sed -i "s/^port = .*/port = ${DB_PORT}/" /etc/postgresql/15/main/postgresql.conf | |||
| RUN npm install --global yarn --force | |||
| RUN curl -fsSL https://deb.nodesource.com/setup_18.x | bash - \ | |||
There was a problem hiding this comment.
I am not sure whether this was required or not. As the base image in this dockerfile is middlewareeng/oss-base, and I suppose this image is being built from Dockerfile.prebuilt(Where I upgraded to node 18)
If my understanding of the code is correct then changes to this file can be removed and a new commit can be made to middlewareeng/oss-base with the updates in the Dockerfile.prebuilt
I am not so sure about my understanding of this
There was a problem hiding this comment.
I am not sure whether this was required or not. As the base image in this dockerfile is
middlewareeng/oss-base, and I suppose this image is being built from Dockerfile.prebuilt(Where I upgraded to node 18) If my understanding of the code is correct then changes to this file can be removed and a new commit can be made tomiddlewareeng/oss-basewith the updates in the Dockerfile.prebuiltI am not so sure about my understanding of this
yep. Not needed here
thesujai
changed the title
Dockerfile.dev
Outdated
| RUN curl -fsSL https://deb.nodesource.com/setup_22.x | bash - \ | ||
| && apt-get install -y nodejs \ | ||
| && npm install --global yarn |
There was a problem hiding this comment.
Why is this required in the dev setup, if we are already using the pre-built base image. This would slow down the dev process.
There was a problem hiding this comment.
Can you push the pre-built base image with the latest changes so I can remove this one? As the old base image has node 16
There was a problem hiding this comment.
Push into dockerhub I mean
|
I will update the base image today @thesujai. |
thesujai
force-pushed
the
node-upgrade-webserver-use-18.19.0
branch
from
3b7284d to
48ac02f
Compare
|
Reverted it! @adnanhashmi09 |
|
I have pushed the latest build with node 22 of oss-base. Please test your PR once and check if everything works. Please rebase and test your pr once. Seems to work fine for me. |
Linked Issue(s)
Fixes #553
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
NA
Further comments
NA