Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fabricitem): enable multi-format support #171

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

❓ What are you trying to address

WIP

✨ Description of new changes

WIP

Copy link

github-actions bot commented Dec 23, 2024

Changelog Preview

v0.1.0-dev - December 31, 2024

💥 Breaking

  • #111 The format attribute is now REQUIRED for Resources/Data-Sources with definition support.
    Currently applicable to the following Resources/Data-Sources: Report, Notebook, Semantic Model, and Spark Job Definition.

✨ Added

  • #168 Added support for multi-format Notebook Resource/Data-Source.
    By using format attribute, you can now define the format of the Notebook Resource/Data-Source. Accepted values are jpynb, and py.

  • #135 Definition support in the fabric_eventhouse Resource

  • #156 Definition support in the fabric_eventhouse Data-Sources

Copy link

github-actions bot commented Dec 23, 2024

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 79% 0
Summary 73% (3873 / 5306) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 76.70%. Comparing base (652870e) to head (02d45d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../pkg/fabricitem/models_resource_item_definition.go 54.54% 5 Missing ⚠️
internal/pkg/fabricitem/data_item_definition.go 72.72% 2 Missing and 1 partial ⚠️
...item/resource_item_config_definition_properties.go 0.00% 3 Missing ⚠️
internal/pkg/fabricitem/definition.go 95.65% 2 Missing ⚠️
internal/pkg/fabricitem/resource_schema.go 91.30% 2 Missing ⚠️
internal/provider/utils/values.go 66.66% 2 Missing ⚠️
internal/pkg/fabricitem/models_resource_item.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   76.58%   76.70%   +0.11%     
==========================================
  Files         148      149       +1     
  Lines       12631    12696      +65     
==========================================
+ Hits         9674     9739      +65     
+ Misses       2952     2951       -1     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from b433182 to 477e796 Compare December 31, 2024 09:18
@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from 477e796 to 2292145 Compare December 31, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants