-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fabric-items): use generic impl #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 08:17 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 08:17 — with
GitHub Actions
Failure
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 08:17 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 08:17 — with
GitHub Actions
Failure
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 08:17 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 08:17 — with
GitHub Actions
Failure
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 08:17 — with
GitHub Actions
Failure
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 08:17 — with
GitHub Actions
Failure
DariuszPorowski
changed the title
feat: refactor warehouse
refactor(warehouse): use generics
Dec 20, 2024
DariuszPorowski
force-pushed
the
refactor/fabitems
branch
from
December 20, 2024 17:59
b8de9a7
to
7b3e885
Compare
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 17:59 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 17:59 — with
GitHub Actions
Error
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 17:59 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 17:59 — with
GitHub Actions
Error
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 17:59 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 17:59 — with
GitHub Actions
Error
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 17:59 — with
GitHub Actions
Error
DariuszPorowski
had a problem deploying
to
development
December 20, 2024 17:59 — with
GitHub Actions
Error
DariuszPorowski
force-pushed
the
refactor/fabitems
branch
from
December 20, 2024 18:02
7b3e885
to
39599dd
Compare
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 20, 2024 18:03 — with
GitHub Actions
Inactive
Minimum allowed line rate is |
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:08 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:08 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:08 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:08 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:08 — with
GitHub Actions
Inactive
Co-authored-by: Pablo Zaidenvoren <2192882+PabloZaiden@users.noreply.github.com>
DariuszPorowski
force-pushed
the
refactor/fabitems
branch
from
December 30, 2024 19:23
7dbaaa8
to
3e2ca4c
Compare
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 19:23 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
had a problem deploying
to
development
December 30, 2024 20:17 — with
GitHub Actions
Failure
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:17 — with
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
development
December 30, 2024 20:42 — with
GitHub Actions
Inactive
PabloZaiden
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been using and reviewing this for the past few days. Really good improvement for codebase simplification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π₯ Pull Request
β What are you trying to address
The main purpose of this PR is to refactor the
fabric-items
module to use a generic implementation and support easy and quick onboarding a new or changing existing Fabric Items.β¨ Description of new changes
Generic implementation for Data-Source:
Generic implementation for Resources:
Refactor of existing modules:
warehouse
: moved to generic implementationenvironment
: moved to generic implementationkql_database
: moved to generic implementationlakehouse
: moved to generic implementationsparkjobdefinition
: moved to generic implementationRefactor of tests: