Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fabric-items): use generic impl #166

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Dec 20, 2024

πŸ“₯ Pull Request

❓ What are you trying to address

The main purpose of this PR is to refactor the fabric-items module to use a generic implementation and support easy and quick onboarding a new or changing existing Fabric Items.

✨ Description of new changes

Generic implementation for Data-Source:

  • item
  • item with properties
  • item with definition and properties
  • items with properties

Generic implementation for Resources:

  • item
  • item with properties
  • item with definition and properties
  • item with configuration and properties
  • item with configuration/definition and properties

Refactor of existing modules:

  • warehouse: moved to generic implementation
  • environment: moved to generic implementation
  • kql_database: moved to generic implementation
  • lakehouse: moved to generic implementation
  • sparkjobdefinition: moved to generic implementation

Refactor of tests:

  • support properties in fakes
  • use dedicated well-known Workspace for Resources/Data-Sources

@DariuszPorowski DariuszPorowski changed the title feat: refactor warehouse refactor(warehouse): use generics Dec 20, 2024
@DariuszPorowski DariuszPorowski added the skip-changelog Skip changelog entry label Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 βœ”
Summary 73% (3828 / 5262) 0 βœ”

Minimum allowed line rate is 40%

Co-authored-by: Pablo Zaidenvoren <2192882+PabloZaiden@users.noreply.github.com>
Copy link

Changelog Preview

v0.1.0-dev - December 30, 2024

✨ Added

  • #135 Definition support in the fabric_eventhouse Resource
  • #156 Definition support in the fabric_eventhouse Data-Sources

Copy link
Contributor

@PabloZaiden PabloZaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using and reviewing this for the past few days. Really good improvement for codebase simplification!

@DariuszPorowski DariuszPorowski merged commit 652870e into main Dec 31, 2024
26 of 27 checks passed
@DariuszPorowski DariuszPorowski deleted the refactor/fabitems branch December 31, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants