Updated MSAL and Azure Identity dependency versions #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyc
requested review from
divang,
Jeffery-Wasty,
Ananya2,
muskan124947,
machavan and
lilgreenbird
Jeffery-Wasty
previously approved these changes
Jan 14, 2025
tkyc
force-pushed
the
dependency-updates
branch
from
350c92c to
f9c184b
Compare
| <azure-identity.version>1.12.2</azure-identity.version> | ||
| <msal.version>1.15.1</msal.version> | ||
| <azure-identity.version>1.15.0</azure-identity.version> | ||
| <msal.version>1.17.2</msal.version> |
There was a problem hiding this comment.
why 1.17.2? latest is 1.18.0
There was a problem hiding this comment.
Dependency version conflicts, latest azure-identity 1.15.0 depends on msal 1.17.2. If I use 1.18.0 it breaks things.
lilgreenbird
requested changes
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
============================================
+ Coverage 51.01% 51.17% +0.15%
- Complexity 3921 3942 +21
============================================
Files 147 147
Lines 33483 33505 +22
Branches 5609 5614 +5
============================================
+ Hits 17081 17145 +64
+ Misses 13991 13959 -32
+ Partials 2411 2401 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the pom.xml with the latest versions of MSAL and Azure Identity.
The project's public Azure Artifact feed is also updated with the latest versions of MSAL and Azure Identity.
To test locally, pull this branch and do a fresh local build with
mvn clean install -DskipTests -T 1C. If it works, your local build run should complete successfully without errors.Search for
Update Public Azure Artifacts Feedin the internal driver docs (not public) to learn more.