-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed exception type to SQLFeatureNotSupported #2583
Open
machavan
wants to merge
4
commits into
main
Choose a base branch
from
dev/machavan/issue2580
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
changed the title
Fixed exception type to SQLfeatureNotSupported
Fixed exception type to SQLFeatureNotSupported
Jan 13, 2025
machavan
requested review from
divang,
codewatchzen,
lilgreenbird,
Jeffery-Wasty,
tkyc and
David-Engel
January 13, 2025 11:53
/azp run public-mssql-jdbc.windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run public-mssql-jdbc.linux |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run CI-MacOS |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
============================================
+ Coverage 51.01% 51.15% +0.14%
- Complexity 3921 3933 +12
============================================
Files 147 147
Lines 33483 33506 +23
Branches 5609 5614 +5
============================================
+ Hits 17081 17141 +60
+ Misses 13991 13954 -37
Partials 2411 2411 ☔ View full report in Codecov by Sentry. |
lilgreenbird
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed exception type to SQLfeatureNotSupported as per the the java.sql.Connection API doc: https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#releaseSavepoint-java.sql.Savepoint-
Testing: