Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception type to SQLFeatureNotSupported #2583

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

machavan
Copy link
Contributor

Fixed exception type to SQLfeatureNotSupported as per the the java.sql.Connection API doc: https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#releaseSavepoint-java.sql.Savepoint-

Testing:

  • Build and unit tests pass
  • Added new unit test for testing this exception

@machavan machavan changed the title Fixed exception type to SQLfeatureNotSupported Fixed exception type to SQLFeatureNotSupported Jan 13, 2025
@lilgreenbird
Copy link
Contributor

/azp run public-mssql-jdbc.windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@machavan
Copy link
Contributor Author

/azp run public-mssql-jdbc.linux

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@machavan
Copy link
Contributor Author

/azp run CI-MacOS

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.15%. Comparing base (5bb3353) to head (0bb9238).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2583      +/-   ##
============================================
+ Coverage     51.01%   51.15%   +0.14%     
- Complexity     3921     3933      +12     
============================================
  Files           147      147              
  Lines         33483    33506      +23     
  Branches       5609     5614       +5     
============================================
+ Hits          17081    17141      +60     
+ Misses        13991    13954      -37     
  Partials       2411     2411              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Non standard exception type is thrown when attempting to use an unsupported feature
2 participants