Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored procedure call returns wrong BigDecimal scale. #2582

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ananya2
Copy link
Contributor

@Ananya2 Ananya2 commented Jan 13, 2025

#2534 - Set scale value dynamically for DECIMAL output parameters in registerOutParameter method.

This change retrieves the scale from the ParameterMetaData and applies it to the DECIMAL output parameter. This provides a more flexible approach for handling DECIMAL data types.

As an alternative, users can directly call registerOutParameter(index, sqlType, scale) to specify the scale explicitly.

@Ananya2 Ananya2 self-assigned this Jan 13, 2025
machavan
machavan previously approved these changes Jan 16, 2025
Copy link
Contributor

@machavan machavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run ADO tests with this branch

@Ananya2
Copy link
Contributor Author

Ananya2 commented Jan 16, 2025

/azp run public-mssql-jdbc.windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ananya2
Copy link
Contributor Author

Ananya2 commented Jan 16, 2025

/azp run public-mssql-jdbc.linux

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ananya2
Copy link
Contributor Author

Ananya2 commented Jan 16, 2025

/azp run CI-MacOS

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.15%. Comparing base (5bb3353) to head (2f3ea63).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2582      +/-   ##
============================================
+ Coverage     51.01%   51.15%   +0.13%     
- Complexity     3921     3928       +7     
============================================
  Files           147      147              
  Lines         33483    33513      +30     
  Branches       5609     5615       +6     
============================================
+ Hits          17081    17142      +61     
+ Misses        13991    13958      -33     
- Partials       2411     2413       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants