BareMetal refactoring: Move capability to cluster, add logger for clusters, remove unused schema, fix dependencies and so on #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
force-pushed
the
1220_baremetal
branch
4 times, most recently
from
0976605 to
4733ade
Compare
1. Add parent logger for clusters. It helps know the sources of cluster logs. 2. Remove extra "cluster" part in log prefix. It makes the log line shorter. 3. Move get_logger to cluster base class from subclasses RackManager and Idrac.
Capability is used for a node, keep it consistent with other platforms.
1. Remove the BM capability, and use the LISA capability. So the BM cap supports all cap fields. 2. Move the capabiltiy construction to cluster level, because cluster knows clients than platform. It's simplified the platform, and ready for future multi-clients refactor. 3. Rename capabilities to capability like other LISA code.
The cluster and client information maybe used in underlying features, so add them.
squirrelsc
force-pushed
the
1220_baremetal
branch
from
4733ade to
6c4a50a
Compare
1. PXE Create SerialConsole when deploying to capture all logs, So it needs to create Featues before it's used. 2. node.initialize is the right way to "initialize" a node, make it functional.
squirrelsc
force-pushed
the
1220_baremetal
branch
from
6c4a50a to
ea33d44
Compare
LiliDeng
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details on commit descriptions.