Fix ch libvirt #3562
Open
Fix ch libvirt #3562
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Dec 20, 2024
praveen-pk
force-pushed
the
fix_ch_libvirt
branch
2 times, most recently
from
0d96c83 to
c9741e8
Compare
|
fyi, working on flake8 failures. |
praveen-pk
force-pushed
the
fix_ch_libvirt
branch
from
c9741e8 to
4562237
Compare
You can follow this doc to set local dev env, so check errors could be fixed locally. https://mslisa.readthedocs.io/en/main/write_test/dev_setup.html |
Properly parse libvirt version and return only the version information. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Libvirt versions greater than 10.2.0, define domain as 'hyperv' or 'kvm' based on the underlying hypervisor. Set this domain appropriately in domain's XML after checking libvirt version. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Enable virtnetworkd service along with libvritd service. virtnetworkd service will setup the default NAT network for guests to use. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
praveen-pk
force-pushed
the
fix_ch_libvirt
branch
from
4562237 to
2863d53
Compare
squirrelsc
reviewed
Dec 31, 2024
| @@ -8,6 +8,8 @@ | |||
| from pathlib import Path | |||
| from typing import List, Type | |||
|
|
|||
| from packaging.version import parse | |||
There was a problem hiding this comment.
Use builtin parse_version in util.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series fixes the libvirt version parsing and sets the domain based on the underlying hypervisor.