-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPDK: Add 32bit test #3489
base: main
Are you sure you want to change the base?
DPDK: Add 32bit test #3489
Conversation
@squirrelsc I'm getting a ton of mypy errors which are due to the old version we're using :\ |
We don't have a plan to upgrade mypy yet, it's not a trivial and safe work. |
Definitely not trivial, tons of errors specifically in the aws and azure sut_orchestrator code 😵💫 |
d435fd6
to
f798f14
Compare
@squirrelsc I've worked out the mypy issues. Should be all good now. |
@LiliDeng LGTM |
ffb6ed2
to
c44ccb9
Compare
* urlparse tar fix Fixing one bug uncovered a few others. Fixes the way the Tar tool handles fetching the filename of the tar file it downloads. * Wget: add caching * Tar: Allow skip-old-files option When running Wget.get(..., force_run=False) and Tar.extract it is useful to allow Tar to skip extracting existing files on the second pass. Allow the skip-old-files option, so Tar.extract will not overwrite existing files in the output directory. Note: it's important to not use this option if you are providing LISA with a default filename for your tarballs. This option could silently allow Tar.extract to not update the contents of a directory with the newer file contents. I don't see anyone using that schema now. My apologies to future devs who find this commit message while debugging that issue. Tar: chi comments * TarDownloader: enable skip_old_files option in tar extract Dpdk: chi comments * Tar: fix subclass prototype * Wget: remove unneeded return
Allowing extension of the class for the 32bit build
Allow building rdma-core and dpdk as 32bit applications before test. Add the 32bit test. This is a beefy commit because we must extend the Installer class to support 32bit builds. This means adding invalid arch checks, adding arch checks to the DependencyInstaller, adding changes to PKG_CONFIG_PATH and allowing updating environment variables everywhere. The result is that we can install DPDK and RDMA core and run their 32bit versions to test basic send/receive stuff.
…nused function from dpdksuite
Add a test which compiles DPDK as a 32bit application before run. Implements basic build and send_receive tests.
Required a little fiddling with meson and pkgconfig to ensure the 32bit libraries are used when needed.