Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support build on *NIX platforms #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

orzel7
Copy link

@orzel7 orzel7 commented Sep 27, 2021

I'm trying to using library on Linux. This is very basic support, but in the future i am going to implement advanced things.

@ghost
Copy link

ghost commented Sep 27, 2021

CLA assistant check
All CLA requirements met.

@bghgary
Copy link
Contributor

bghgary commented Oct 28, 2021

Sorry @orzel7. We missed this PR somehow. I think it would be great if we can get some CI for linux before merging or this will break again.

@joaquin4d
Copy link

this PR is great, any timeframe for getting this merged?

@bghgary
Copy link
Contributor

bghgary commented Dec 16, 2021

We can merge, but with a CI being added, it may break easily. Anyone want to take a stab at adding Linux CI?

@joaquin4d
Copy link

joaquin4d commented Dec 16, 2021

Don't see any docs explaining what you mean, so I ask. Do you mean:

  • adding tests for linux? (but seems to me tests described in CMakeLists.txt don't exclude Linux platform)
  • adding github actions for Linux? (but currently there are none anyway for any platform)
  • adding a test specifically for testing if it builds on Linux? (but shouldn't this be just the act of compiling it on Linux?)

@bghgary
Copy link
Contributor

bghgary commented Dec 16, 2021

We use Azure DevOps to do CI. It should be mostly just changing this file: https://github.com/microsoft/glTF-SDK/blob/master/Build/AzureDevOps/azure-pipelines.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants