Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix draco extension deserialization #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vb002
Copy link

@vb002 vb002 commented May 10, 2023

doc.GetObject() returns non const GenericObject which is reseted during GenericValue construction (https://github.com/Tencent/rapidjson/blob/master/include/rapidjson/document.h#L872). It means that such object becomes empty after calling GetMemberValueAsString (as in DeserializeDracoMeshCompression) so you can't use it further. In current master attributes are read after calling GetMemberValueAsString which leads to missing extension params.

doc.GetObject() returns non const GenericObject which is reseted during GenericValue construction (https://github.com/Tencent/rapidjson/blob/master/include/rapidjson/document.h#L872). It means that such object becomes empty after calling GetMemberValueAsString (as in DeserializeDracoMeshCompression) so you can't use it further. In current master version attributes are read after calling GetMemberValueAsString which leads to incomplete extension params.
@vb002 vb002 changed the title Update ExtensionsKHR.cpp Fix draco extension deserialization May 10, 2023
@vb002
Copy link
Author

vb002 commented May 10, 2023

@vb002 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@bghgary
Copy link
Contributor

bghgary commented Nov 29, 2023

Ouch, sorry, I just noticed we never responded to this. Is this still needed?

@vb002
Copy link
Author

vb002 commented Nov 29, 2023

Hi, I think that this problem is still actual.

@bghgary
Copy link
Contributor

bghgary commented Nov 29, 2023

Would it be possible for you to add a quick unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants