ci: separate VRT pipelines in GHA compliant pattern for future enablement #33534
+291
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Hotell
force-pushed
the
ci/migrate-to-gha-vrt/1
branch
from
36fc7a7 to
4768a9f
Compare
Hotell
changed the title
Hotell
commented
Dec 31, 2024
apps/vr-tests-react-components/src/stories/Button/Button.stories.tsx
Outdated
Show resolved
Hide resolved
Hotell
changed the title
Hotell
commented
Dec 31, 2024
| - run: yarn playwright install --with-deps | ||
|
|
||
| - name: Run VR tests (generate screenshots) | ||
| run: yarn nx affected -t test-vr --nxBail |
There was a problem hiding this comment.
this saves significant resources
- before: install,playwright setup, scrernshot generation was done N times ( per affected projects )
- after: setup is invoked only once
Hotell
commented
Dec 31, 2024
| echo "MAKE THIS WORK" | ||
| npx vr-approval-cli@0.4.11 run-diff --screenshotsDirectory ./screenshots --buildType pr --clientType "FLUENTUI" --threshold '0.04' --cumThreshold '1' | ||
|
|
||
| # 💡 NOTE: |
Hotell
commented
Dec 31, 2024
| actions: 'read' | ||
|
|
||
| jobs: | ||
| run_vr_diff: |
There was a problem hiding this comment.
this is preparation of generated screenshots on forks and PR id, that will be used in vrt diffing tool once we have new version
Hotell
commented
Dec 31, 2024
| @@ -84,58 +84,64 @@ runs: | |||
| path: screenshots | |||
|
|
|||
| # ========================================================== | |||
| # STEPS BELOW WILL FAIL TO RUN ON GITHUB ACTIONS - see TODOs | |||
| # STEPS BELOW WILL FAIL TO RUN ON GITHUB ACTIONS - see @TODOs | |||
There was a problem hiding this comment.
commenting steps that would not work with this composite action for future reference for us and VRT team
github-actions
bot
modified the milestones:
December Project Cycle Q4 2024,
January Project Cycle Q1 2025
Hotell
commented
Jan 2, 2025
| * @param {import('../../scripts/triage-bot/src/types.ts').GithubScriptsParams & {config:{projects:string[]}} } options | ||
| * @returns | ||
| */ | ||
| async function main(options) { |
There was a problem hiding this comment.
- aggregates screenshots generated during
nx affectedunder/screenshotsdirectory - generates
screenshots-report.jsonwith metadata for further processing within*-commentworkflow ( wish this functionality would be baked in within the vrt tool like we have for bundle size )
Hotell
commented
Jan 2, 2025
| @@ -12,7 +8,7 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| env: | |||
| NX_PARALLEL: 4 # ubuntu-latest = 4-core CPU / 16 GB of RAM | macos-14-xlarge (arm) = 6-core CPU / 14 GB of RAM | |||
| NX_PARALLEL: 6 # ubuntu-latest = 4-core CPU / 16 GB of RAM | macos-14-xlarge (arm) = 6-core CPU / 14 GB of RAM | |||
There was a problem hiding this comment.
we can use powerful ARM agents ( generation is executed via webpack and storywright ( playwright ) )
Hotell
force-pushed
the
ci/migrate-to-gha-vrt/1
branch
from
afd9dbc to
9412478
Compare
dmytrokirpa
approved these changes
Jan 2, 2025
| }); | ||
|
|
||
| console.info(`✅ ${screenshotsPath} contents copied to ${destinationFolder}`); | ||
| report[project] = { path: project }; |
There was a problem hiding this comment.
Is it a map of the affected vr-tests-* app projects? Not sure if it'd be useful to include it in the PR comment. I know that we don't have this info just yet, but we might want to post a link to the vr-tool diff app instead
dmytrokirpa
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Splits/Implements VRT pipelines in 2 to follow GHA pattern on forks for future enablement.
Out of scope:
Related Issue(s)