Ameliorating runtime speed by adding in optimizations that make the code more concise #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 6, 2019 15:03
Changed the GetAppViewState function from an if else statement to a tertiary check to help with faster loading.
Refactoring to speed up loading time
The end result of the CloseCalendarFlyout() method always will be that the IsCalendarOpen in the for DateDiff_FromDate and DateDiff_ToDate will be false. For this, checking to see if they are true before making them false is redundant. They will be false when the method is called, no matter what.
This makes the code more clear and concise without having unnecessary boolean checks, for the branches can go straight into acting once and then returning m_token.
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
#209
Description of the changes:
How changes were validated: