Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run > Calculator] Update mages to v3.0.0 and support for randi(n) #36560

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Dec 25, 2024

Summary of the Pull Request

  • Updates nuget package for mages to version 3.0.0
  • Adds new math function randi(n) to input validation. (Random integer between 0 and n.)

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Test new math function in local build.

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek changed the title update to mages 3.0.0 [PT Run > Calculator] Update mages to v3.0.0 and support for randi(n) Dec 25, 2024
@htcfreek htcfreek self-assigned this Dec 25, 2024
@htcfreek htcfreek added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Dec 25, 2024
@htcfreek htcfreek marked this pull request as ready for review December 25, 2024 15:28
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 25, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Gave it some tests and seems to be working well still :) Thank you for the contribution.

@jaimecbernardo jaimecbernardo merged commit 94d7121 into microsoft:main Jan 3, 2025
11 checks passed
@htcfreek htcfreek deleted the PT_Mages3 branch January 3, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
Development

Successfully merging this pull request may close these issues.

2 participants