Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
There are a few things in hyperkzg that make upstream usage impossible or difficult. In particular, the actual proof is inaccessible in a transparent fashion.
Changes
Take a look at the individual commits.
Default
for hyperkzgProverKey
ProverKey
is a placeholder for hyperzkg.hat_P.len()
is not1 << point.len()
, theprove
method currently panics. This commit padshat_P
with 0s instead, allowing for more flexible upstream usage.