Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve hyperkzg api #353

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JayWhite2357
Copy link

@JayWhite2357 JayWhite2357 commented Jan 11, 2025

Rationale

There are a few things in hyperkzg that make upstream usage impossible or difficult. In particular, the actual proof is inaccessible in a transparent fashion.

Changes

Take a look at the individual commits.

This allows upstream usage to access the actual proof directly. In particular, this is useful for custom seralization.
This is convienient because the `ProverKey` is a placeholder for hyperzkg.
If `hat_P.len()` is not `1 << point.len()`, the `prove` method currently panics. This commit pads `hat_P` with 0s instead, allowing for more flexible upstream usage.
Currently, hyperkzg does not work if the point is empty. This commit simply defaults to using a trivial point. This default respects the commitment and evaluation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant