Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark variables with segment numbers #341

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Acentelles
Copy link

This PR marks variables with "rounds" or "segments". This will allow us to build randomized circuits made from interactive protocols of the following form:

  • The prover sends a vector w1
  • The verifier sends a challenge c
  • The prover then sends another vector w2.
  • Then the verifier performs some checks on the vector (w1, w2, c, 1, x) where x is public IO.

When the witness vector is constructed, we want the code to be able to automatically build w1, w2, etc. so they can be committed separately. We could think of witness to be committed in segments or chunks or rounds. So, when allocating a variable, we want to be able to specify the "segment number".

We want to make sure if within a namespace we call some gadget, all variables allocated inside the gadget fall into the same segment as the caller.

Forpee and others added 10 commits November 6, 2024 12:38
commit cd8559dd3b08261121e4ac797bd364de317c9467
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 12:38:02 2024 +0200

    chore: restore cargo

commit f190e75d215b8a73d66c559d427b5e536ddb9c4e
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 12:32:32 2024 +0200

    chore: fix warnings, docs, clippy, fmt

commit b849a82e2d142c0fd1564721785295c67c4f2d34
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 11:56:28 2024 +0200

    chore: do some doc comments

commit 1fb584f14216f187a42b0eae9e5550042c08e31c
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 11:39:23 2024 +0200

    chore: clean up warnings

commit c68b709c53e812bac02bf09f43c08b0f8ce9f1bb
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 11:28:21 2024 +0200

    feat: add alloc_precommitted

commit 1642f15efb44c88a990f3e84e9c2a9d11b7bb735
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 11:18:36 2024 +0200

    feat: init precommitted var

commit 4aa27a7a32073bf6a3e87d5a9f9cafc2a305b853
Author: Forpee <khalilhassam3@gmail.com>
Date:   Wed Nov 6 10:53:59 2024 +0200

    chore: make poseidon folder

commit 110e782d888e56c9ea2fba75b807e201f97bc2c1
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 23:05:29 2024 +0200

    chore: rm doc tests

commit e9426b2d30078841c2b17492ce96e26e19d41d47
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 23:05:04 2024 +0200

    fix: poseidon in pp

commit aa12cbf04bdab6e5d18f45dceb0de6f33dd25dd5
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 22:04:57 2024 +0200

    feat: init new CS

commit 54cb3dfd0df2cc4bbde97b475daa4058680d14ff
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 20:38:43 2024 +0200

    feat: port poseidon sponge

commit e1368fdd74cd52cbcf65143e6e19d391a861ad66
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 20:34:12 2024 +0200

    feat: implement poseidon

commit 3d2e6fad71016afcec88f24c8219240e366f047e
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 18:41:20 2024 +0200

    feat: poseidon consts

commit f002464ab64933aa05667976ea9a2e3249ba552d
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 18:41:09 2024 +0200

    feat: init CS

commit 9ee87f60e2073ceb9031a93f1056ef10fb241ce2
Author: Forpee <khalilhassam3@gmail.com>
Date:   Tue Nov 5 14:40:46 2024 +0200

    fix: cargo

@Acentelles please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@@ -72,7 +72,7 @@ name = "ppsnark"
harness = false

[features]
default = ["halo2curves/asm"]
# default = ["halo2curves/asm"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: bring this back?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can bring it back. The reason is that I get the following error when I compile the code with this default enabled:

Currently feature `asm` can only be enabled on x86_64 arch.

This means that the assembly optimizations feature in halo2curves is only compatible with x86_64 architecture processors, and I am running an ARM processor (Apple M3 in particular).

Maybe I can open an issue with it. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-x86 platforms, one could use --no-default-features. See for example:

https://github.com/microsoft/Nova?tab=readme-ov-file#tests-and-examples

@srinathsetty
Copy link
Collaborator

@Acentelles in the current PR, the witness isn't committed separately i.e., segment by segment, right?

@Acentelles
Copy link
Author

Right, the witness isn't committed separately in this PR. Is that something you'd like to add?

@srinathsetty
Copy link
Collaborator

Right, the witness isn't committed separately in this PR. Is that something you'd like to add?

Yes, otherwise, we won't have use for marking witness elements with segment numbers. See #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants