Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transitive jackson-databind dependency from httpclient-netty #725

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Remove transitive jackson-databind dependency from httpclient-netty #725

merged 2 commits into from
Oct 16, 2023

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Oct 11, 2023

I think this will need a minor release.

@graemerocher
Copy link
Contributor

graemerocher commented Oct 11, 2023 •
edited
Loading

It is runtime and not API scoped so is fine to remove, lets see if the tests pass

@yawkat
Copy link
Member Author

yawkat commented Oct 11, 2023

youre right, it seems the netty client doesnt depend on it after all.

@yawkat
Copy link
Member Author

yawkat commented Oct 11, 2023

i mean the httpclient-common.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yawkat yawkat merged commit b007eef into master Oct 16, 2023
13 checks passed
@yawkat yawkat deleted the exclude-jackson branch October 16, 2023 09:04
@yawkat yawkat added the type: improvement A minor improvement to an existing feature label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosanchez alvarosanchez alvarosanchez approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yawkat @graemerocher @alvarosanchez