support user accounts should not be locked #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly more correct instantiation of support user accounts. Without a password specified,
useraddmakes the password field!, which locks the account - however,UsePAMin/etc/sshd_configignores that and allows users to log in anyways if some other auth mechanism is used. In our default AmpliPisshd_configthis is not a problem because we haveUsePAM. However, a user ships their own custom and very reasonable sshd_config that setsUsePAM no, which prevented the support tunnel user from being able to authenticate. This PR fixes that.There are more details here (archive.org).