Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin sqlmodel==0.0.19 because of changes in UUID handling #26

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

rtertiaer
Copy link
Contributor

This PR pins sqlmodel to 0.0.19. sqlmodel introduced much better UUID handling in 0.0.20, but implementing their methodology will require more testing than this simple change. This chnage fixes the device context cleaning up tunnel resources, which presents like:

(venv) pi@amplipi:/opt/support_tunnel $ inv stop [snipped tunnel id]
Traceback (most recent call last):                                                                                                 
  File "/opt/support_tunnel/venv/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1816, in _execute_context                dialect, self, conn, execution_options, *args, **kw                                                                            
  File "/opt/support_tunnel/venv/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 1463, in _init_compiled               for key in positiontup                                                                                                         
  File "/opt/support_tunnel/venv/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 1463, in <listcomp>                   for key in positiontup                                                                                                         
  File "/opt/support_tunnel/venv/lib/python3.7/site-packages/sqlalchemy/sql/sqltypes.py", line 3608, in process                        value = value.hex                                                                                                              
AttributeError: 'str' object has no attribute 'hex'          

I also filed #25 for tracking that future work.

Copy link

@mjustian mjustian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rtertiaer rtertiaer merged commit 2fbaaf7 into main Aug 8, 2024
2 checks passed
@rtertiaer rtertiaer deleted the pin_sqlmodel branch August 8, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants