Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use GitHub Action #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: use GitHub Action #21

wants to merge 3 commits into from

Conversation

ldez
Copy link

@ldez ldez commented Mar 20, 2024

Replace Travis with GitHub Action.

@mibk
Copy link
Owner

mibk commented Apr 30, 2024

Thank you for your contributions, but I'm not sure I can merge this as is.

  • “chore: update Go version” seems fine as it is. I'd be happy to merge this.
  • “chore: add .gitignore” appears unnecessary. The .idea directory can be added to the global .gitignore file instead.
  • “chore: use GitHub Actions” I don't have experience with GitHub Actions, and this seems a bit too complex for a tool that's essentially in maintenance mode. Including a Makefile is not necessary at all.

@ldez
Copy link
Author

ldez commented May 4, 2024

“chore: use GitHub Actions” I don't have experience with GitHub Actions, and this seems a bit too complex for a tool that's essentially in maintenance mode. Including a Makefile is not necessary at all.

Currently, you are using Travis but Travis is dead, which means you have no CI.
Even if the project is in maintenance mode, I think a CI is always useful.

The Makefile is just a way to document the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants