Moving ATA checks to IX #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danenbm
reviewed
Sep 27, 2024
| @@ -68,4 +68,5 @@ jobs: | |||
| name: rust-client-builds | |||
| # First wildcard ensures exported paths are consistently under the clients folder. | |||
| path: ./targe*/release/*mpl_hybrid* | |||
| include-hidden-files: true | |||
There was a problem hiding this comment.
Nit: I don't think you need hidden files for this path because its not in .bin or "dot" anything so its not hidden.
Comment on lines
+23
to
+24
| mp14o4AQcmE5meFDxCscervMc1E4zyKEyDp3398PcwU.json | ||
| MPL4o4wMzndgh8T1NVDxELQCj5UQfYTYEkabX3wNKtb.json |
There was a problem hiding this comment.
Did you want these in the .gitignore? Seems like specific thing to add when I think normally they could be anywhere.
Comment on lines
+52
to
+54
| /// CHECK: We check and initialize the token account below. | ||
| #[account(mut)] | ||
| user_token_account: AccountInfo<'info>, |
There was a problem hiding this comment.
Isn't it technically advised to use UncheckedAccount instead of AccountInfo for this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the ATA checks internal to the IX instead of anchor constraints to optimize stack usage.