-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new methods #11
base: main
Are you sure you want to change the base?
Add new methods #11
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"Executable", | ||
"ProgrammableNFT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After these now belong "MplCoreAsset" and "MplCoreCollection"
} | ||
}, | ||
{ | ||
"name": "getAssetProofs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new ones (getAssets
, getAssetProofs
, getAssetSignatures
) should probably be added to the README table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing this one in open RPC: https://playground.open-rpc.org/?url=https://raw.githubusercontent.com/metaplex-foundation/digital-asset-standard-api/febo/asset-methods/specification/metaplex-das-api.json
To the mainline one: https://playground.open-rpc.org/?url=https://raw.githubusercontent.com/metaplex-foundation/digital-asset-standard-api/main/specification/metaplex-das-api.json
We lose the content descriptors at the top level, which looks like it was intentional in the original PR (looks like original line 487 is where it was cut from)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with couple minor comments
reactivate this PR