chore(ingester): remove panic from account processor job start #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armyhaylenko
requested review from
StanChe,
kstepanovdev,
andrii-kl and
n00m4d
armyhaylenko
force-pushed
the
chore/MTG-1168-remove-account-processor-expect
branch
from
6f68603 to
4f69e0e
Compare
| .await | ||
| .expect("Failed to build 'AccountsProcessor'!"); | ||
| .await { | ||
| Ok(processor) => break processor, |
There was a problem hiding this comment.
The approach seems to be fine. However, shouldn't it accept a "cancellation token" or handle the shutdown channel for a graceful shutdown?
Nvm, looks good. Seems like update_rent doesn't care much about shutdown_rx.
kstepanovdev
approved these changes
Jan 16, 2025
armyhaylenko
force-pushed
the
chore/MTG-1168-remove-account-processor-expect
branch
from
4f69e0e to
841529b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.